mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.
Date Wed, 24 Jul 2019 13:34:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71082/
-----------------------------------------------------------

(Updated July 24, 2019, 1:34 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Extended comments, fixed `construct<T>` for protobufs.


Bugs: MESOS-9864
    https://issues.apache.org/jira/browse/MESOS-9864


Repository: mesos


Description
-------

Added a helper to create std::vector from iterable into python bindings.


Diffs (updated)
-----

  src/python/native_common/common.hpp ed743aab014301981fe2526a7e81f4a35c02e19b 


Diff: https://reviews.apache.org/r/71082/diff/3/

Changes: https://reviews.apache.org/r/71082/diff/2-3/


Testing
-------

With valid arguments - see next patches.
Ran with invalid arguments manually.


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message