mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.
Date Tue, 23 Jul 2019 21:35:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71082/#review216818
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, I only held off on committing this because I don't have a python build handy to
test that removing the redundant declaration would compile successfully.


src/python/native_common/common.hpp
Lines 155-159 (patched)
<https://reviews.apache.org/r/71082/#comment304071>

    Is this still needed? Looks like a declaration of the definition above?



src/python/native_common/common.hpp
Lines 201 (patched)
<https://reviews.apache.org/r/71082/#comment304072>

    Period at the end


- Benjamin Mahler


On July 23, 2019, 4:13 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71082/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 4:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9864
>     https://issues.apache.org/jira/browse/MESOS-9864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper to create std::vector from iterable into python bindings.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/common.hpp ed743aab014301981fe2526a7e81f4a35c02e19b 
> 
> 
> Diff: https://reviews.apache.org/r/71082/diff/2/
> 
> 
> Testing
> -------
> 
> With valid arguments - see next patches.
> Ran with invalid arguments manually.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message