mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71111: Added offer rescind logic for guarantees enforcement.
Date Tue, 23 Jul 2019 21:21:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71111/#review216817
-----------------------------------------------------------


Fix it, then Ship it!




Ditto here, could you add the caveat about the under-rescind to the commit description?


src/master/quota_handler.cpp
Lines 662-667 (patched)
<https://reviews.apache.org/r/71111/#comment304067>

    Thanks!



src/tests/master_quota_tests.cpp
Lines 1733 (patched)
<https://reviews.apache.org/r/71111/#comment304069>

    Do you mean Offered here?



src/tests/master_quota_tests.cpp
Lines 1735-1736 (patched)
<https://reviews.apache.org/r/71111/#comment304070>

    This seems a bit weak as a test? But I suppose we don't want to write a test that's revealing
the quirks of the current under/over rescind implementation?



src/tests/master_quota_tests.cpp
Lines 1736 (patched)
<https://reviews.apache.org/r/71111/#comment304068>

    Outstanding


- Benjamin Mahler


On July 23, 2019, 8:39 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71111/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 8:39 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9812
>     https://issues.apache.org/jira/browse/MESOS-9812
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Outstanding offers need to be rescinded as needed to ensure
> roles' requested guarantees can be satisfied.
> 
> For simplicity, and also due to the race between the master and
> the allocator, we pessimistically assume that what seems like
> "available" resources in the allocator are all gone. We greedily
> rescind offers until we can satisfy the guarantees.
> 
> Also added a test.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125 
>   src/tests/master_quota_tests.cpp 8105765172f17f3ea50aa09bc66fede8d21365ab 
> 
> 
> Diff: https://reviews.apache.org/r/71111/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message