mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71084: Added unsuppressing via `updateFramework()` to python example framework.
Date Tue, 23 Jul 2019 20:38:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71084/#review216814
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71082, 71083, 71084]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On July 16, 2019, 3:14 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71084/
> -----------------------------------------------------------
> 
> (Updated July 16, 2019, 3:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9864
>     https://issues.apache.org/jira/browse/MESOS-9864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch ensures that the list of suppressed roles is passed through
> the `updateFramework()` of python V0 bindings. Now the framework
> subscribes with all roles suppressed and after that issues
> UPDATE_FRAMEWORK call to unsuppress offers.
> 
> 
> Diffs
> -----
> 
>   src/examples/python/test_framework.py 27bc052dc4e57e0290ef58a39b2f1ac82fdb42fd 
> 
> 
> Diff: https://reviews.apache.org/r/71084/diff/1/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.PythonFramework*" --gtest_break_on_failure
--gtest_repeat=5`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message