mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71144: Added `reconciliation_interval_seconds` for storage resource providers.
Date Tue, 23 Jul 2019 20:00:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71144/#review216809
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Lines 1155 (patched)
<https://reviews.apache.org/r/71144/#comment304058>

    WDYT about dropping the part about the default value? That way we would have freedom to
e.g., switch to a flag-driven value down the line without break any formal API contract.
    
    Similar in v1.


- Benjamin Bannier


On July 23, 2019, 9:53 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71144/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 9:53 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9254
>     https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new configuration option controls how frequent a storage resource
> provider reconciles existing volumes and storage pools against its CSI
> plugin to detect new or missing disk resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2b4f350815935220c2d2b0dd0e52346bc74c91d9 
>   include/mesos/v1/mesos.proto bafc27499f810791700c4a30dcb1da33b6f31d2e 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/resource_provider/constants.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71144/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message