mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.
Date Tue, 23 Jul 2019 16:20:22 GMT


> On July 18, 2019, 5:59 p.m., Benjamin Mahler wrote:
> > Looks like I will wait until the egg issue is fixed

I haven't managed to find a **simple**, portable and non-racy way to simultaneously build
two python eggs which need the same source. 
Gave up and moved that template specialization into the header (with `inline` specifier).

The right solution is to build the common code as a static library and use it from all eggs,
however I'm not sure that this 10-line function is worth it. Left that as TODO.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71082/#review216739
-----------------------------------------------------------


On July 23, 2019, 4:13 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71082/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 4:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9864
>     https://issues.apache.org/jira/browse/MESOS-9864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper to create std::vector from iterable into python bindings.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/common.hpp ed743aab014301981fe2526a7e81f4a35c02e19b 
> 
> 
> Diff: https://reviews.apache.org/r/71082/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message