mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71055: Added drain and deactivation info to master API output.
Date Tue, 16 Jul 2019 17:51:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71055/#review216663
-----------------------------------------------------------


Ship it!




I'm assuming that adding a new event to the streaming API (when an agent is updated) is out
of scope for this review.

- Joseph Wu


On July 12, 2019, 5:01 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71055/
> -----------------------------------------------------------
> 
> (Updated July 12, 2019, 5:01 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Joseph Wu.
> 
> 
> Bugs: MESOS-9816
>     https://issues.apache.org/jira/browse/MESOS-9816
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds the drain info and deactivation state of agents
> to the master's responses for the GET_STATE and GET_AGENTS
> calls, as well as the '/state' and '/state-summary'
> endpoints.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 399e27ebc8358ed27fb03a2ddd455be6027ed0c0 
>   include/mesos/v1/master/master.proto 62bcee59b7cd909ae574b3bd2474883d2cd5d660 
>   src/common/protobuf_utils.hpp 893022b54afff34cb4714e8476cc7f27a8ac1379 
>   src/common/protobuf_utils.cpp 0112fcbbcd438e00f70a1801871d15ea47357d0a 
>   src/master/http.cpp cd0f40cb7b966d6620e3fb49d4c08807185c9101 
>   src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742 
>   src/master/readonly_handler.cpp f4432a54a21134192636b76a5c36d0241e10dabc 
> 
> 
> Diff: https://reviews.apache.org/r/71055/diff/1/
> 
> 
> Testing
> -------
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message