mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70924: Added registry operations for DE/RE-ACTIVATE_AGENT calls.
Date Tue, 16 Jul 2019 17:42:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70924/#review216662
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On July 8, 2019, 6:39 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70924/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 6:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9814
>     https://issues.apache.org/jira/browse/MESOS-9814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds the associated registry operation and fields for the
> DEACTIVATE_AGENT and REACTIVATE_AGENT master calls.
> 
> Like the DRAIN_AGENT call, the deactivation state also persists when
> agents become unreachable/reachable, which is already handled by the
> DRAIN_AGENT operation implementation.
> 
> Likewise, this feature is not downgrade compatible, and a minimum
> capability is added when the deactivation feature is used.
> If all draining or deactivated agents are reactivated, the minimum
> capability is removed.
> 
> 
> Diffs
> -----
> 
>   src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b 
>   src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4 
>   src/tests/registrar_tests.cpp 5f0de523705d124ddd2d21ad355f06633d68c141 
> 
> 
> Diff: https://reviews.apache.org/r/70924/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message