mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 70887: Added `PendingFutureTracker` class for tracking pending futures.
Date Tue, 16 Jul 2019 16:41:47 GMT


> On Июль 16, 2019, 6:53 д.п., Gilbert Song wrote:
> > src/common/future_track.hpp
> > Lines 40 (patched)
> > <https://reviews.apache.org/r/70887/diff/3/?file=2154659#file2154659line40>
> >
> >     Do you need the args to be ordered? If not, probably we could use `unordered_map`
(or our stout hashmap wrapper)? the complexity is O(1) in average.

Yeah, it might be easier to read those arguments if they're sorted alphabetically.
Complexity is a non-sense here since there are hardly a dozen of arguments. If there is a
proof that `map` causes performance issues here, we could fix it.


> On Июль 16, 2019, 6:53 д.п., Gilbert Song wrote:
> > src/common/future_track.hpp
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/70887/diff/3/?file=2154659#file2154659line83>
> >
> >     For efficiency, if we are not expecting to erase frequently, we should use `vector`
instead of `list`.
> >     
> >     in this class, the process will erase pending futures frequently?

Please see this comment: https://reviews.apache.org/r/70887/#comment303380


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70887/#review216614
-----------------------------------------------------------


On Июнь 19, 2019, 2:49 п.п., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70887/
> -----------------------------------------------------------
> 
> (Updated Июнь 19, 2019, 2:49 п.п.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng Zhu, and Qian
Zhang.
> 
> 
> Bugs: MESOS-9837
>     https://issues.apache.org/jira/browse/MESOS-9837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a mechanism for tracking pending futures.
> This feature allows detection of hanging operations, which get
> stuck on a blocking operation or asynchronously. However, this
> feature does not provide any mechanism for tracking pending
> promises, because `Promise` objects might not be accessible in
> various cases. Thereby, we introduce a new class that can be
> used to track pending futures, so it might facilitate debugging
> of stuck issues.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/common/future_tracker.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70887/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message