mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70889: Wrapped isolators in `IsolatorTracker`.
Date Tue, 16 Jul 2019 12:22:26 GMT


> On July 16, 2019, 3:29 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 550-552 (patched)
> > <https://reviews.apache.org/r/70889/diff/2/?file=2154668#file2154668line550>
> >
> >     seems like we are going to have one more libprocess process for each isolator/module.
we may have some concerns on perf.
> >     
> >     would you mind to collect some perf data for w/o isolatorTracker and compare?
> >     
> >     A quick method to test it out is to use mesos-executor and launch 100 containers
in one single task group.

I think the performance overhead should be acceptable. Yes, we add a libprocess `PendingFutureTrackerProcess`,
but for each isolator's method, we just need to dispatch a call (i.e., `PendingFutureTrackerProcess::addFuture`)
to that libprocess but no need to wait for that libprocess to complete that call, so the performance
overhead are just some functions calls but no extra thread switches.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70889/#review216643
-----------------------------------------------------------


On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70889/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 10:49 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-9841
>     https://issues.apache.org/jira/browse/MESOS-9841
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch wraps every isolator in instance of `IsolatorTracker` class.
> If an isolator gets stuck in some operation, `pendingFutures` will
> return the isolator name, method name along with its arguments such as
> `containerId`, `pid`, etc.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp d33c65cd3fae9bb4d347681cb00dbdb25ecf57b8

>   src/slave/containerizer/containerizer.cpp 5ce0d9c4bfa707495ea644c90fa6e35eb0fe25cd

>   src/slave/containerizer/mesos/containerizer.hpp 558e412b28a84ae0ca1bf05b596540072bb216d6

>   src/slave/containerizer/mesos/containerizer.cpp c9a369bcdbfc1676912430c3e84fa567bbd7f766

>   src/slave/main.cpp ef5ea02f169427d9913b807664bf3073d72cd9b6 
>   src/tests/cluster.hpp c04ee14beafe350568a295c8258566aa3704028a 
>   src/tests/cluster.cpp b43f806eab096b7d4e86e2b5d4b81d6baecb0ee5 
> 
> 
> Diff: https://reviews.apache.org/r/70889/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message