-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70892/#review216645
-----------------------------------------------------------
this patch lgtm! thx!
- Gilbert Song
On June 19, 2019, 7:49 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70892/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 7:49 a.m.)
>
>
> Review request for mesos, Gilbert Song, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9829
> https://issues.apache.org/jira/browse/MESOS-9829
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch introduces an agent's `/containerizer/debug` endpoint,
> which exposes the debug info related to Mesos containerizer.
> Currently, this endpoint returns a list of pending futures related to
> isolators or containerizer launcher. This endpoint is experimental,
> and the format of its output may change over time.
>
>
> Diffs
> -----
>
> src/local/local.cpp 6ac6b027f66ef555440ca86803198bfe3227f8d7
> src/slave/http.hpp b8c83f1db95c2175bb94f6cd76cc2c58aa118c4e
> src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4
> src/slave/main.cpp ef5ea02f169427d9913b807664bf3073d72cd9b6
> src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
> src/tests/cluster.hpp c04ee14beafe350568a295c8258566aa3704028a
> src/tests/cluster.cpp b43f806eab096b7d4e86e2b5d4b81d6baecb0ee5
> src/tests/mock_slave.hpp c057b40d6db433f52d1dfe10ae02a3b0bc936564
> src/tests/mock_slave.cpp dd458e3d09e212d6cde514d86989878954f79fc1
>
>
> Diff: https://reviews.apache.org/r/70892/diff/3/
>
>
> Testing
> -------
>
> Manual testing.
> 1. Add `::sleep(5)` to the beginning of the `LinuxSeccompIsolatorProcess::prepare` method.
> 2. Rebuild Mesos and then spin up a local Mesos cluster.
> 3. Run simple task, e.g.:
> ```
> ./src/mesos-execute --master="`hostname`:5050" --name="test" --containerizer=mesos --command="sleep
1"
> ```
> 4. In the parallel terminal session:
> ```
> curl `hostname`:5051/containerizer/debug
> # will return: {"pending":[["linux/seccomp::prepare",{"containerId":"<container id>"}]]}
> ```
> 5. After 5 seconds this endpoint returns an empty list of pending futures: `{"pending":[]}`
>
> Unit tests: TBD in the following patches.
>
>
> Thanks,
>
> Andrei Budnik
>
>
|