mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71069: Added end-to-end tests for agent draining.
Date Tue, 16 Jul 2019 00:40:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71069/
-----------------------------------------------------------

(Updated July 16, 2019, 12:40 a.m.)


Review request for mesos, Benno Evers and Joseph Wu.


Summary (updated)
-----------------

Added end-to-end tests for agent draining.


Bugs: MESOS-9816
    https://issues.apache.org/jira/browse/MESOS-9816


Repository: mesos


Description (updated)
-------

This adds a minimal test for the DRAIN_AGENT scheduler call,
including verification of master API results once an agent
has been drained. A second test verifies the case where an
agent is marked gone when draining is complete.


Diffs (updated)
-----

  include/mesos/v1/mesos.hpp df67f64fc537819bf8607e6d6b4a478b544df69e 
  src/tests/api_tests.cpp af1d215f00c8c2224e807677afb4af2d3521235a 
  src/v1/mesos.cpp be479e34042fb4a76b770d4a0e9abe454ff0447b 


Diff: https://reviews.apache.org/r/71069/diff/2/

Changes: https://reviews.apache.org/r/71069/diff/1-2/


Testing
-------

`make check`
`bin/mesos-tests.sh --gtest_filter="*MasterAPITest.DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message