mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70959: Cleared agent drain state when draining is finished.
Date Mon, 15 Jul 2019 17:26:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70959/#review216611
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On June 28, 2019, 9:27 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70959/
> -----------------------------------------------------------
> 
> (Updated June 28, 2019, 9:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9860
>     https://issues.apache.org/jira/browse/MESOS-9860
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Once a draining agent has neither frameworks with pending tasks nor any
> executors with either queued or launched tasks it has finished draining.
> This patch adds handling of that case which clears both the in-memory
> and persisted drain configuration.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70959/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> tested as part of https://reviews.apache.org/r/70960/
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message