mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fei long <carlonel...@gmail.com>
Subject Re: Review Request 71024: Supported insecure registry when provisioning docker images.
Date Sun, 14 Jul 2019 10:35:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71024/
-----------------------------------------------------------

(Updated July 14, 2019, 10:35 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.


Changes
-------

Changed insecure_docker_registry(string) to use_insecure_docker_registry(bool) and added a
unit test.


Bugs: MESOS-6183
    https://issues.apache.org/jira/browse/MESOS-6183


Repository: mesos


Description
-------

Supported insecure registry when provisioning docker images.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp d013c9d71c39c09e600f181aba31b8037aa9226a

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2

  src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 
  src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 
  src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 
  src/tests/containerizer/provisioner_docker_tests.cpp 5d5a355afd9c4fda1c653d6cecb75703b0f2222e

  src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 
  src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 


Diff: https://reviews.apache.org/r/71024/diff/2/

Changes: https://reviews.apache.org/r/71024/diff/1-2/


Testing
-------

All testing cases passed.


Thanks,

fei long


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message