mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 71068: Added offer rescind logic for limits enforcement.
Date Fri, 12 Jul 2019 22:02:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71068/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9812
    https://issues.apache.org/jira/browse/MESOS-9812


Repository: mesos


Description
-------

Outstanding offers of a role (including offers allocated to its
subroles) are rescinded until the sum of its consumed quota and
outstanding offered resources are below the requested limits.

The rescind logic here, however, overlooks the race between master
and the allocator. Namely, there might be pending offers in the master
mailbox that have yet to be processed. Here, for simplicity, we ignore
this race. To properly handle this, the plan is to move offer
management logic into the allocator and rescind offers there.

Also added a test.


Diffs
-----

  src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607 
  src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58 


Diff: https://reviews.apache.org/r/71068/diff/1/


Testing
-------

Ran continously without failure.


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message