mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71041: Added best-effort validation for DRAIN_AGENT master call.
Date Tue, 09 Jul 2019 22:54:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71041/#review216458
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp
Lines 3937-3969 (patched)
<https://reviews.apache.org/r/71041/#comment303695>

    Could you add a TODO somewhere here to perform these checks on unreachable agents once
we keep their full SlaveInfo? You could reference this JIRA: https://issues.apache.org/jira/browse/MESOS-9884


- Greg Mann


On July 9, 2019, 7:29 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71041/
> -----------------------------------------------------------
> 
> (Updated July 9, 2019, 7:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9814
>     https://issues.apache.org/jira/browse/MESOS-9814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds two cases which the master cannot deterministically enforce
> when using the DRAIN_AGENT call.  The draining feature is currently
> incompatible with maintenance schedules and older versions of the
> Mesos agent.  However, in both cases, an agent can reregister with
> incompatible info after starting to drain.  Also, unreachable agents
> do not have enough info to enforce either case.
> 
> These are unexpected cases and are not expected to cause any problems
> if circumvented.  However, the agent draining feature is also not
> expected to work correctly if circumvented.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c 
> 
> 
> Diff: https://reviews.apache.org/r/71041/diff/1/
> 
> 
> Testing
> -------
> 
> TODO
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message