mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 70996: Implemented master endpoints for agent draining.
Date Tue, 09 Jul 2019 19:27:31 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 9, 2019, 12:27 p.m.)

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.


Added/modified some comments and style.
Changed `reactivate` to include a CHECK.

Bugs: MESOS-9814

Repository: mesos


This fleshes out three master calls:

The master now stores a mapping of agent draining or deactivation
information.  When an agent reconnects, this information is checked
before informing the allocator about the agent.

This commit leaves out certain aspects of each endpoint's validation,
such as checking if draining agents are not in maintenance schedules.

The DRAIN_AGENT call is not completely implemented here, because the
transition from DRAINING to DRAINED will be added in a separate commit.

Diffs (updated)

  src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c 
  src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 
  src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742 




TODO: At this point, there isn't anything exposed by the master which can be used to check
the results of these APIs.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message