mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71031: Updated LaunchTask test action to use a unique TaskID across runs.
Date Tue, 09 Jul 2019 17:02:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71031/#review216446
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On July 8, 2019, 10:47 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71031/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 10:47 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The existing incremented counter is problematic if the action is
> used multiple times in a test, as the task id will clash across
> usages.
> 
> No tests appear to rely on the existing task id assignment scheme,
> so this updates it to be randomly unique via UUID.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp d0c82fa4c1800ed2a1825d563a9462ecd41b77fd 
> 
> 
> Diff: https://reviews.apache.org/r/71031/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message