mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 71024: Supported insecure registry when provisioning docker images.
Date Tue, 09 Jul 2019 05:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71024/#review216441
-----------------------------------------------------------



Can you add some unit test for this? For instance, toggle the new agent flag, test with some
docker registry (ideally, an unsecure registry, but I think it's ok to test with a secure
one too just to excersize the code path).


src/slave/flags.hpp
Lines 61 (patched)
<https://reviews.apache.org/r/71024/#comment303682>

    I would rather make this a boolean


- Jie Yu


On July 9, 2019, 3:24 a.m., fei long wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71024/
> -----------------------------------------------------------
> 
> (Updated July 9, 2019, 3:24 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6183
>     https://issues.apache.org/jira/browse/MESOS-6183
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported insecure registry when provisioning docker images.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp d013c9d71c39c09e600f181aba31b8037aa9226a

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2

>   src/slave/flags.hpp a10bf698dc447b1411c06083c2ba7585d7a78389 
>   src/slave/flags.cpp b4e3eb99221a09404dbbf813da33607867a78691 
>   src/slave/http.cpp 69e6d74e8b113cc6c937f47df8984ff9a63e5bb4 
>   src/uri/fetchers/docker.hpp 2bb921474f3a8147d8cbf54579452f8df216d2f1 
>   src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 
> 
> 
> Diff: https://reviews.apache.org/r/71024/diff/1/
> 
> 
> Testing
> -------
> 
> All testing cases passed.
> 
> 
> Thanks,
> 
> fei long
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message