mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71030: Added quota_consumption field to /roles endpoint.
Date Tue, 09 Jul 2019 00:27:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71030/#review216435
-----------------------------------------------------------



As mentioned in previous patch, add composition? A TODO is fine.


src/master/readonly_handler.cpp
Lines 738 (patched)
<https://reviews.apache.org/r/71030/#comment303673>

    I am thinking we should just call it `consumption`, `quota_consumption` might throw some
people off guard if a role has default quota (where user did not set any quota on). It is
also more clean to me, as we say allocation, not quota_allocation.
    
    If we change this, should also change the accessor function name.


- Meng Zhu


On July 8, 2019, 11:07 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71030/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 11:07 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9871
>     https://issues.apache.org/jira/browse/MESOS-9871
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per the previous commit that adds the quota consumption computation,
> quota consumption is:
> 
>   Allocation + Unallocated Reservation ==
>   Reservations + Unreserved Allocation
> 
> That is, reservations count towards quota regardless of whether
> they're allocated. Allocation counts towards quota. Offered resources
> *do not* count towards quota, this is to (1) provide stability of the
> quota consumption metrics in the face of offers flowing in and out,
> and (2) to ensure that we treat offers as rescindable and therefore
> not yet "counting" towards quota. Also, if in the future schedulers
> are offered more than their quota to improve their choices, counting
> offered resources as quota consumption will be problematic.
> 
> 
> Diffs
> -----
> 
>   src/master/readonly_handler.cpp 0d1e3dc19352863263c3e8992a63852c7f27225b 
>   src/tests/role_tests.cpp bf5b3cba59d38eee41ed222d14bc8c928fcf2a79 
> 
> 
> Diff: https://reviews.apache.org/r/71030/diff/1/
> 
> 
> Testing
> -------
> 
> Added a test in a subsequent patch.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message