mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 70757: Added a NNP isolator.
Date Mon, 08 Jul 2019 23:28:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70757/#review216428
-----------------------------------------------------------




src/slave/containerizer/mesos/launch.cpp
Lines 1175 (patched)
<https://reviews.apache.org/r/70757/#comment303661>

    This check should move to the isolator creation factory function. It's typical for isolators
to enforce prerequisites there.



src/tests/containerizer/linux_nnp_isolator_tests.cpp
Lines 44 (patched)
<https://reviews.apache.org/r/70757/#comment303663>

    `cout` isn't used.



src/tests/containerizer/linux_nnp_isolator_tests.cpp
Lines 85 (patched)
<https://reviews.apache.org/r/70757/#comment303656>

    Add a newline.



src/tests/containerizer/linux_nnp_isolator_tests.cpp
Lines 94 (patched)
<https://reviews.apache.org/r/70757/#comment303664>

    You can just use `ASSERT_SOME` on the `version` here.



src/tests/containerizer/linux_nnp_isolator_tests.cpp
Lines 99 (patched)
<https://reviews.apache.org/r/70757/#comment303662>

    Here, and in the isolator check, I think that we should phrase this as:
    ```
    kernel version >= xx.yy.zz
    ```
    
    I think that the `+` could be misread as part of the version name.



src/tests/containerizer/linux_nnp_isolator_tests.cpp
Lines 100 (patched)
<https://reviews.apache.org/r/70757/#comment303665>

    Maybe `LOG(INFO)`, and make the message say that you are skipping the test.



src/tests/containerizer/linux_nnp_isolator_tests.cpp
Lines 129 (patched)
<https://reviews.apache.org/r/70757/#comment303666>

    I think this would be more readable with a raw string, i.e:
    
    ```
    R"~(
    ...
    )~"
    ```
    
    There's a few examples of tests that use this for scripts.


- James Peach


On July 4, 2019, 12:26 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70757/
> -----------------------------------------------------------
> 
> (Updated July 4, 2019, 12:26 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9770
>     https://issues.apache.org/jira/browse/MESOS-9770
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds the isolation capability of flipping the
> NO_NEW_PRIVILEGES bit for process control.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 2d04f3c182a4274dda527a3da56c894c3c892a12 
>   src/CMakeLists.txt 1d4f541b73c07a307a8b61f217e0cfad5dc095e4 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/slave/containerizer/mesos/containerizer.cpp 043244841a73fa3f5f7119bc38f6d3a04be8990b

>   src/slave/containerizer/mesos/isolators/linux/nnp.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/nnp.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/launch.cpp b29ec556399a40aa662987a11a2b64e6a16de889 
>   src/tests/CMakeLists.txt 3ea8b4400ff3b00470aa147cb8f39f62802727e3 
>   src/tests/containerizer/linux_nnp_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70757/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message