mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.
Date Mon, 08 Jul 2019 23:04:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71034/#review216430
-----------------------------------------------------------




src/docker/executor.hpp
Lines 157 (patched)
<https://reviews.apache.org/r/71034/#comment303658>

    Missing after the type `const Option<KillPolicy>`, an `&`



src/docker/executor.cpp
Line 932 (original), 938-950 (patched)
<https://reviews.apache.org/r/71034/#comment303657>

    Can you try disambiguating like this:
    ```
    // Need to disambiguate overloaded function.
    void (DockerExecutorProcess::*killTask)(
        ExecutorDriver*, const TaskID&, const Option<KillPolicy>&)
      = &DockerExecutorProcess::killTask;
    
    return process::dispatch(
      process.get(), killTask, driver, taskId, None());
    ```



src/docker/executor.cpp
Lines 980 (patched)
<https://reviews.apache.org/r/71034/#comment303659>

    Missing `&` after the Option<>.


- Joseph Wu


On July 8, 2019, 11:25 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71034/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 11:25 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
>     https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a new `killTask()` overload to the Docker executor
> and updates the Mesos executor driver to call into that
> overload when the loaded executor is the Docker executor.
> 
> This allows the executor driver to pass the kill policy
> override, when present, into the Docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/exec/exec.cpp c0fa3b61667da96bc4395bae9956c54446268122 
> 
> 
> Diff: https://reviews.apache.org/r/71034/diff/1/
> 
> 
> Testing
> -------
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message