mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71028: Renamed the roles ui column from 'Allocation' to 'Allocation + Offered'.
Date Mon, 08 Jul 2019 22:53:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71028/#review216429
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On July 8, 2019, 10:46 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71028/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 10:46 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This column actually displays the allocation + offered amount, so this
> renames it accordingly to avoid confusion. Later, we will split these
> apart into separate selectable columns.
> 
> 
> Diffs
> -----
> 
>   src/webui/app/roles/roles.html 02cb7ba09845d4f9b51630d9c59c1bbd533ac478 
> 
> 
> Diff: https://reviews.apache.org/r/71028/diff/1/
> 
> 
> Testing
> -------
> 
> make check and rendered the UI locally
> 
> 
> File Attachments
> ----------------
> 
> Roles Table
>   https://reviews.apache.org/media/uploaded/files/2019/07/08/41785a71-2676-4ff6-8653-2d10442605e1__Screen_Shot_2019-07-08_at_1.43.37_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message