mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70923: Added a registry operation for the DRAIN_AGENT call.
Date Mon, 08 Jul 2019 18:38:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70923/
-----------------------------------------------------------

(Updated July 8, 2019, 11:38 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
-------

Updated to use the minimum capability helper.


Bugs: MESOS-9814
    https://issues.apache.org/jira/browse/MESOS-9814


Repository: mesos


Description
-------

This adds the associated registry operation and fields for the
DRAIN_AGENT master call.  This call affects admitted or unreachable
agents, but this commit only deals with admitted agents.
    
Because this feature is not downgrade compatible, a minimum capability
is added when the draining feature is used.


Diffs (updated)
-----

  src/master/registry.proto 67904edf73235a4007f7c59c05dc4f1abab1cd08 
  src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b 
  src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4 
  src/tests/registrar_tests.cpp 5f0de523705d124ddd2d21ad355f06633d68c141 


Diff: https://reviews.apache.org/r/70923/diff/4/

Changes: https://reviews.apache.org/r/70923/diff/3-4/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message