mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 71035: Added test to verify that Docker executor can override kill policy.
Date Mon, 08 Jul 2019 18:28:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/
-----------------------------------------------------------

Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
    https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
-------

This adds a test which verifies that when a scheduler attemps to
override a task's default kill policy, the Docker executor will
honor that override.


Diffs
-----

  src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478 
  src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d 
  src/tests/containerizer/docker_containerizer_tests.cpp a6217581e20168c5114f733323e927a83ac59fd0



Diff: https://reviews.apache.org/r/71035/diff/1/


Testing
-------

`make check`
`sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" --gtest_repeat=-1
--gtest_break_on_failure`

Verified that this new test fails on current master, and passes when the preceding patches
in this chain are applied.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message