mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71018: Fixed a race between status updates and acknowledgements in SLRP tests.
Date Sun, 07 Jul 2019 23:34:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71018/#review216413
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On July 5, 2019, 11:56 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71018/
> -----------------------------------------------------------
> 
> (Updated July 5, 2019, 11:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.
> 
> 
> Bugs: MESOS-9881
>     https://issues.apache.org/jira/browse/MESOS-9881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SLRP tests `RetryOperationStatusUpdate*` check that no operation update
> will be sent by SLRP once acknowledgements are sent by master. However,
> since the acknowledgements are delivered via HTTP, it is possible that
> operation status updates race with acknowledgements that are still in
> HTTP pipes. This patch fixes this race condition.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 38233053452259571743317326a6efc74d97bd29

> 
> 
> Diff: https://reviews.apache.org/r/71018/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the tests under stress 200 times.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message