mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71021: Implemented `UPDATE_QUOTA` operator call.
Date Sun, 07 Jul 2019 22:37:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71021/#review216410
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp
Line 383 (original), 383 (patched)
<https://reviews.apache.org/r/71021/#comment303628>

    (oh interesting, none of these std::move the call into the handler yet)



src/master/quota_handler.cpp
Lines 440-441 (patched)
<https://reviews.apache.org/r/71021/#comment303627>

    Hm.. did you intend to copy here? Looks like it should be a const reference.



src/master/quota_handler.cpp
Line 441 (original), 444 (patched)
<https://reviews.apache.org/r/71021/#comment303629>

    since this line is getting touched, `const auto&`?



src/master/quota_handler.cpp
Line 479 (original), 482 (patched)
<https://reviews.apache.org/r/71021/#comment303630>

    since you're touching this line, `const auto&`?



src/master/quota_handler.cpp
Lines 559 (patched)
<https://reviews.apache.org/r/71021/#comment303631>

    Can you clarify in the commit description that there remains work to rescind offers?
    
    Reading the summary/description I thought this patch would "complete" the implementation
of the endpoint (which made me wonder how that was done without the consumption patch).



src/tests/master_tests.cpp
Line 5039 (original), 5039 (patched)
<https://reviews.apache.org/r/71021/#comment303632>

    At what point to we consider a master officially `QUOTA_V2` capable?
    
    i.e. can you clarify this in the commit description when mentioning that we're now adding
the `QUOTA_V2` capability? It's not that clear to me (e.g. master quota v2 api is capable
of writes, and master is capable of recovering from v2 quota in registry?)


- Benjamin Mahler


On July 7, 2019, 10:12 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71021/
> -----------------------------------------------------------
> 
> (Updated July 7, 2019, 10:12 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8968
>     https://issues.apache.org/jira/browse/MESOS-8968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch wires up the master, auth, registar and allocator
> pieces for `UPDATE_QUOTA` call.
> 
> This enables the master capability `QUOTA_V2`.
> 
> Also enabled test `MasterQuotaTest.RecoverQuotaEmptyCluster`.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.cpp 13b3467825c624fd3cb1652fbfec1a9631ca37e6 
>   src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c 
>   src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 
>   src/master/quota_handler.cpp f9c743170461d8d83180db20c917d3842241d4df 
>   src/tests/master_quota_tests.cpp 34a652029e31827f8d94bb66d408fbe3d121fd8f 
>   src/tests/master_tests.cpp f817450793b7469b8ac465c2e84a9d6fc5b4bc68 
> 
> 
> Diff: https://reviews.apache.org/r/71021/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> tests in r/71022/
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message