mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71013: Fixed flaky test `UpdateFrameworkV0Test.SuppressedRoles`.
Date Thu, 04 Jul 2019 15:44:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71013/#review216385
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71013]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On July 4, 2019, 1:56 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71013/
> -----------------------------------------------------------
> 
> (Updated July 4, 2019, 1:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9882
>     https://issues.apache.org/jira/browse/MESOS-9882
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, the test has been failing in cases when the first
> AGENT_ADDED message arrived after setting an expectation for the
> "second" one. After this patch, expectations for both messages are set,
> and this is performed before any of them can arrive.
> 
> 
> Diffs
> -----
> 
>   src/tests/master/update_framework_tests.cpp dda09fcd8f6e3cc268bf6897cd58a6444510bd16

> 
> 
> Diff: https://reviews.apache.org/r/71013/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message