mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.
Date Thu, 04 Jul 2019 15:12:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70921/#review216382
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


CHANGELOG
Lines 9 (patched)
<https://reviews.apache.org/r/70921/#comment303598>

    s/should/will/



CHANGELOG
Lines 27 (patched)
<https://reviews.apache.org/r/70921/#comment303599>

    How about:
    
    ... will now forego TLS certificate verification ...



CHANGELOG
Lines 27 (patched)
<https://reviews.apache.org/r/70921/#comment303600>

    How about:
    
    ... will now forego TLS certificate verification ...



docs/upgrades.md
Lines 516 (patched)
<https://reviews.apache.org/r/70921/#comment303601>

    s/change/configure/



docs/upgrades.md
Lines 526 (patched)
<https://reviews.apache.org/r/70921/#comment303602>

    How about?
    ```  * For incoming connections, certificates are not verified unless `LIBPROCESS_SSL_REQUIRE_CERT`
is set to true.
    ```



docs/upgrades.md
Lines 527 (patched)
<https://reviews.apache.org/r/70921/#comment303603>

    This is really hard to parse but right now I am unable to come up with something easier
for the eye -- lets try to improve this with some native speaker help.


- Till Toenshoff


On June 21, 2019, 3:02 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70921/
> -----------------------------------------------------------
> 
> (Updated June 21, 2019, 3:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added OpenSSL-related changes to CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG ecd01d6f415859eb6b9cfa3468db02d1810a3998 
>   docs/upgrades.md 4a818df4993093770b49efb675b8078c42144241 
> 
> 
> Diff: https://reviews.apache.org/r/70921/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message