mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings.
Date Wed, 03 Jul 2019 22:32:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70947/#review216363
-----------------------------------------------------------




src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Lines 396-398 (patched)
<https://reviews.apache.org/r/70947/#comment303565>

    Why the extra level of indirection? Why not just make this native like the others?


- Benjamin Mahler


On July 3, 2019, 5:03 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70947/
> -----------------------------------------------------------
> 
> (Updated July 3, 2019, 5:03 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
>     https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `reviveOffers(roles)` to V0 Java bindings.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp f81a69a7f13f976a09f11409a0ea3f40fccea1b8

>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 772a7383328519e63f0bf31908cb4c2129a77315

>   src/java/src/org/apache/mesos/SchedulerDriver.java 155e4ac7b0e507c549a2d2de07ab95e215bf39e0

> 
> 
> Diff: https://reviews.apache.org/r/70947/diff/3/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure
--gtest_repeat=10` with a patch from https://reviews.apache.org/r/70946/
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message