mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70995: Fixed bugs in updating framework roles in the hierarchial allocator.
Date Wed, 03 Jul 2019 21:00:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70995/#review216362
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp
Lines 533 (patched)
<https://reviews.apache.org/r/70995/#comment303564>

    s/roles/roles /


- Benjamin Mahler


On July 2, 2019, 7:12 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70995/
> -----------------------------------------------------------
> 
> (Updated July 2, 2019, 7:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9870
>     https://issues.apache.org/jira/browse/MESOS-9870
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch replaces the largest part of the logic around
> suppressing/unsuppressing framework roles in the 'updateFramework()'
> method with calling 'suppressRoles()'/'unsuppress()' methods, which
> are used for processing SUPPRESS/REVIVE calls.
> 
> This fixes bugs which are triggered by simulatneous updates of
> framework's roles and its suppressed roles (see MESOS-9870), namely:
>  - master crashes due to changing nonexistent role metrics
>  - master crash due to activating removed frameworkSorter
>  - spurious activation of a role added in suppressed state
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 26aad6778f12b99bb87c846788d6b6d60f743d8a

> 
> 
> Diff: https://reviews.apache.org/r/70995/diff/1/
> 
> 
> Testing
> -------
> 
> make check + new tests in dependent patches
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message