mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70942: Added a test for 'reviveOffers(roles)'.
Date Wed, 03 Jul 2019 15:58:52 GMT


> On June 25, 2019, 7:44 p.m., Benjamin Mahler wrote:
> > src/tests/scheduler_driver_tests.cpp
> > Lines 514-516 (patched)
> > <https://reviews.apache.org/r/70942/diff/2/?file=2152156#file2152156line514>
> >
> >     This seems unnecessary?
> 
> Andrei Sekretenko wrote:
>     Removed this `settle()`. 
>     
>     It does nothing useful except for preventing a potential race between `EXPECT_CALL(resourceOffers,
...)` and the driver calling `resourceOffers()` (which is possible only if the offer filters
/ framework update are broken).
>     And testing offer filters / framework update is not the purpose of this test.

I was mistaken. There is a reason why we need to `settle()` here. It prevents reordering of
updateFramework() and revive() in the allocator, which is possible if master processes REVIVE
while UPDATE_FRAMEWORK is being authorized.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70942/#review216130
-----------------------------------------------------------


On July 3, 2019, 3:55 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70942/
> -----------------------------------------------------------
> 
> (Updated July 3, 2019, 3:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
>     https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for 'reviveOffers(roles)'.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_driver_tests.cpp 80f3335b0054ed0e458c175700765293dfd6a929 
> 
> 
> Diff: https://reviews.apache.org/r/70942/diff/4/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="MesosSchedulerDriverTest*ReviveSingleRole*" --gtest_break_on_failure
--gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message