mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <>
Subject Review Request 70995: Fixed bugs in updating framework roles in the hierarchial allocator.
Date Tue, 02 Jul 2019 19:12:06 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Mahler and Meng Zhu.

Bugs: MESOS-9870

Repository: mesos


This patch replaces the largest part of the logic around
suppressing/unsuppressing framework roles in the 'updateFramework()'
method with calling 'suppressRoles()'/'unsuppress()' methods, which
are used for processing SUPPRESS/REVIVE calls.

This fixes bugs which are triggered by simulatneous updates of
framework's roles and its suppressed roles (see MESOS-9870), namely:
 - master crashes due to changing nonexistent role metrics
 - master crash due to activating removed frameworkSorter
 - spurious activation of a role added in suppressed state


  src/master/allocator/mesos/hierarchical.cpp 26aad6778f12b99bb87c846788d6b6d60f743d8a 



make check + new tests in dependent patches


Andrei Sekretenko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message