mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70923: Added a registry operation for the DRAIN_AGENT call.
Date Mon, 01 Jul 2019 22:49:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70923/#review216288
-----------------------------------------------------------




src/master/registry_operations.cpp
Lines 388-402 (patched)
<https://reviews.apache.org/r/70923/#comment303434>

    For the time being, we can use:
    
    https://github.com/apache/mesos/blob/3720e4cf5f7cb0d8e98afacea39528bd41c767b4/src/common/protobuf_utils.hpp#L501-L513


- Meng Zhu


On June 26, 2019, 1:44 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70923/
> -----------------------------------------------------------
> 
> (Updated June 26, 2019, 1:44 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9814
>     https://issues.apache.org/jira/browse/MESOS-9814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds the associated registry operation and fields for the
> DRAIN_AGENT master call.  This call affects admitted or unreachable
> agents, but this commit only deals with admitted agents.
>     
> Because this feature is not downgrade compatible, a minimum capability
> is added when the draining feature is used.
> 
> 
> Diffs
> -----
> 
>   src/master/registry.proto 239789322c45c6a8346332f50661a98b1851b685 
>   src/master/registry_operations.hpp 5a3010d46c4eddb0d660eb7368ec836903477a9b 
>   src/master/registry_operations.cpp c417c4d6c4272eeab15f5313ca5160d4a0aa4da4 
>   src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8 
> 
> 
> Diff: https://reviews.apache.org/r/70923/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message