mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
Date Tue, 02 Jul 2019 19:39:13 GMT
jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340#issuecomment-507816894
 
 
   Yes, I think this makes sense to include.
   
   On Tue, Jul 2, 2019 at 2:32 PM Vinod Kone <notifications@github.com> wrote:
   
   > *@vinodkone* commented on this pull request.
   >
   > LGTM. Should we add the extra bit about the expectation when TTY is
   > enabled? See comment here:
   > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/io/switchboard.cpp#L1727
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/mesos/pull/340?email_source=notifications&email_token=AAR5KLCWPPLENB32KV7KPSTP5ONNVA5CNFSM4H426542YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5JKNXQ#pullrequestreview-257074910>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAR5KLCXS5QC7MHPSD6YDZDP5ONNVANCNFSM4H42654Q>
   > .
   >
   
   
   -- 
   James DeFelice
   585.241.9488 (voice)
   650.649.6071 (fax)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message