mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70951: Updated registry operation `UpdateQuota` to persist `QuotaConfig`.
Date Wed, 26 Jun 2019 06:03:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70951/
-----------------------------------------------------------

(Updated June 25, 2019, 11:03 p.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-----------------

Updated registry operation `UpdateQuota` to persist `QuotaConfig`.


Bugs: MESOS-9601
    https://issues.apache.org/jira/browse/MESOS-9601


Repository: mesos


Description (updated)
-------

The new operations will mutate the `quota_configs` field in
the registry to persist `QuotaConfigs` configured by the new
`UPDATE_QUOTA` call as well as the legacy `SET_QUOTA` and
`REMOVE_QUOTA` calls.

The operation removes any entries in the legacy `quotas` field
with the same role name. In addition, it also adds/removes the
minimum capability `QUOTA_V2` accordingly: if `quota_configs`
is empty the capability will be removed otherwise it will
be added.

This operation replaces the `REMOVE_QUOTA` operation.

Also fixed affected tests.


Diffs (updated)
-----

  src/master/master.cpp 826362d1a9ed034a49934b1810d6e1e6cffd90cd 
  src/master/quota.hpp 959e312b861fc0b59519a9ab5cc51061b55b534c 
  src/master/quota.cpp a7ee845d5916e859218b0168c7b682f77549aafc 
  src/master/quota_handler.cpp 476e87eb67e07a2ec6c7b258667cf94ff9c4f8eb 
  src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8 


Diff: https://reviews.apache.org/r/70951/diff/2/

Changes: https://reviews.apache.org/r/70951/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message