mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <>
Subject Re: Review Request 70749: Introduced optional new algorithm for hostname validation.
Date Wed, 19 Jun 2019 14:46:00 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 19, 2019, 2:45 p.m.)

Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.

Summary (updated)

Introduced optional new algorithm for hostname validation.

Bugs: MESOS-9809

Repository: mesos


This commit introduces a new libprocess SSL flag
`hostname_validation_algorithm`, which can be used to select
between the previous hostname validation behaviour and a new
option to use standardized OpenSSL algorithms to handle
hostname validation as part of the

As a nice side-effect, the new algorithm gets rid of reverse DNS
lookups during TLS connection establishment, which used to be
a common source of hard-to-debug unresponsiveness in Mesos

See `docs/` in the follow-up commit for details of and
differences between the algorithms.

Diffs (updated)

  3rdparty/libprocess/include/process/ssl/flags.hpp f3483f97f93bb29117b2c78f0f2ed9735d9c4b3a

  3rdparty/libprocess/src/openssl.hpp 17bec246e516261f8d772f1647c17f092fae82d1 
  3rdparty/libprocess/src/openssl.cpp e7dbd67913fa8e7fbbf60dee428e7e38895f86ce 
  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp 6ef5a86566af3439cfe0b06ab3576076623f7be0

  3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 29a1bf71c1df9d80370455a6269ecea0ec4193b0






Benno Evers

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message