mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.
Date Wed, 12 Jun 2019 19:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70755/#review215854
-----------------------------------------------------------




src/tests/master/update_framework_tests.cpp
Lines 696-697 (original), 693-695 (patched)
<https://reviews.apache.org/r/70755/#comment302791>

    Now that I see this, it seems odd? `updateFramework()` should require that the ID is set,
since it has been assigned by the time the caller calls this? (technically it's possible that
it hasn't but that seems a very rare case we shouldn't worry about, since the scheduler can't
have really done anything prior to getting an ID).


- Benjamin Mahler


On June 12, 2019, 6:47 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70755/
> -----------------------------------------------------------
> 
> (Updated June 12, 2019, 6:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9793
>     https://issues.apache.org/jira/browse/MESOS-9793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the V0 UPDATE_FRAMEWORK scheduler call.
> 
> 
> Diffs
> -----
> 
>   src/tests/master/update_framework_tests.cpp 78304c211c5eb9f50ea629121a6dddfe47942e9f

> 
> 
> Diff: https://reviews.apache.org/r/70755/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message