mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70735: Added methods to subtract `ResourceQuantities` from `ResourceLimits`.
Date Wed, 29 May 2019 16:37:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70735/
-----------------------------------------------------------

(Updated May 29, 2019, 9:37 a.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Changes
-------

Addressed Ben's comment.


Bugs: MESOS-8456
    https://issues.apache.org/jira/browse/MESOS-8456


Repository: mesos


Description
-------

This patch also makes `ResourceLimits` a friend class of
`ResourceQuantities` to achieve one-pass operation complexities.

Also added unit test.


Diffs (updated)
-----

  src/common/resource_quantities.hpp 21f08c6114de4f8459c0a5f7e25d7b6bba0f060b 
  src/common/resource_quantities.cpp eb741e36669da4ebd1936c1d9caf7266b6105dbb 
  src/tests/resource_quantities_tests.cpp ebe53be4129cceb4429c45d098a718987f557d3a 


Diff: https://reviews.apache.org/r/70735/diff/2/

Changes: https://reviews.apache.org/r/70735/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message