mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70730: Pulled out `shrinkResources()` in the allocator as a resource utility.
Date Wed, 29 May 2019 16:08:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70730/
-----------------------------------------------------------

(Updated May 29, 2019, 9:08 a.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Changes
-------

Addressed Ben's comment. Pulled the lambda into resource utils.


Summary (updated)
-----------------

Pulled out `shrinkResources()` in the allocator as a resource utility.


Repository: mesos


Description
-------

This reduce the clutter in the allocator code.
Also added dedicated unit tests.


Diffs (updated)
-----

  src/common/resources_utils.hpp 42b6cafa3dbcdcce67690dd359c4aecb517ffd1d 
  src/common/resources_utils.cpp 3786bcf3ab61048c3a92e41acb4e43fd787d54f8 
  src/master/allocator/mesos/hierarchical.cpp 40c8363afddccdd5275ca06318a8cc2cc6fa21af 
  src/tests/resources_tests.cpp dbae0f6d7832a941cd04f3d76493f3e486c3909b 


Diff: https://reviews.apache.org/r/70730/diff/2/

Changes: https://reviews.apache.org/r/70730/diff/1-2/


Testing
-------

make check
Benchmark result in r/70731/


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message