mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70737: Added a method to shrink `Resources` to target `ResourceLimits`.
Date Tue, 28 May 2019 17:23:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70737/#review215542
-----------------------------------------------------------



Let's keep this out of the resources class to start with, much like we did with the original
shrink function. Unless there are some clear non-allocator use cases for it?

As it stands, the randomness make it seem inappropriate as a general Resources member function.


include/mesos/resources.hpp
Lines 552-565 (original), 557-583 (patched)
<https://reviews.apache.org/r/70737/#comment302270>

    What's the difference between these two functions? I would suggest documenting them together
as one, with some clarity about how they're different. Rather than duplicating the same documentation
and leaving it to the reader to figure out the subtle difference.


- Benjamin Mahler


On May 28, 2019, 2:55 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70737/
> -----------------------------------------------------------
> 
> (Updated May 28, 2019, 2:55 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8456
>     https://issues.apache.org/jira/browse/MESOS-8456
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added unit tests.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 609ca61a0ffa80a7b10e6a3ebb0caa15966c3371 
>   src/common/resources.cpp 543820de435eb4869fbb93534fa00c58a9c5dfdd 
>   src/tests/resources_tests.cpp dbae0f6d7832a941cd04f3d76493f3e486c3909b 
> 
> 
> Diff: https://reviews.apache.org/r/70737/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message