mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70733: Added `==` and `!=` operators to `ResourceLimits`.
Date Tue, 28 May 2019 17:19:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70733/#review215539
-----------------------------------------------------------


Ship it!




Can you expand the description about when this is used? It's not obvious to me. I can imagine
tests might want to compare them?

- Benjamin Mahler


On May 28, 2019, 2:34 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70733/
> -----------------------------------------------------------
> 
> (Updated May 28, 2019, 2:34 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `==` and `!=` operators to `ResourceLimits`.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp 21f08c6114de4f8459c0a5f7e25d7b6bba0f060b 
>   src/common/resource_quantities.cpp eb741e36669da4ebd1936c1d9caf7266b6105dbb 
> 
> 
> Diff: https://reviews.apache.org/r/70733/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message