mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70730: Made `shrink()` a member function of `Resources`.
Date Tue, 28 May 2019 17:17:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70730/#review215538
-----------------------------------------------------------



Why move it into Resources when we intentionally chose not to? What are the non allocator
use cases for this?

- Benjamin Mahler


On May 28, 2019, 11:59 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70730/
> -----------------------------------------------------------
> 
> (Updated May 28, 2019, 11:59 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reduce the clutter in the allocator code.
> Also added dedicated unit tests.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 609ca61a0ffa80a7b10e6a3ebb0caa15966c3371 
>   src/common/resources.cpp 543820de435eb4869fbb93534fa00c58a9c5dfdd 
>   src/master/allocator/mesos/hierarchical.cpp 40c8363afddccdd5275ca06318a8cc2cc6fa21af

>   src/tests/resources_tests.cpp dbae0f6d7832a941cd04f3d76493f3e486c3909b 
> 
> 
> Diff: https://reviews.apache.org/r/70730/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> Benchmark result in r/70731/
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message