mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70721: Fixed incorrect comparision introduced in `0ab27c674b7`.
Date Sun, 26 May 2019 20:28:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70721/#review215524
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On May 26, 2019, 2:10 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70721/
> -----------------------------------------------------------
> 
> (Updated May 26, 2019, 2:10 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As written the code was comparing a `TaskState` against a
> `v1::TaskState` which are different enums. This was not only brittle and
> not guaranteed to work, but very likely also not intended.
> 
> This patch fixes the code to compare values of the same enum type.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 61d516ce24401199bac9b3984158e9257dda072c 
> 
> 
> Diff: https://reviews.apache.org/r/70721/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message