mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 70721: Fixed incorrect comparision introduced in `0ab27c674b7`.
Date Sun, 26 May 2019 14:10:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70721/
-----------------------------------------------------------

Review request for mesos, Greg Mann and Joseph Wu.


Repository: mesos


Description
-------

As written the code was comparing a `TaskState` against a
`v1::TaskState` which are different enums. This was not only brittle and
not guaranteed to work, but very likely also not intended.

This patch fixes the code to compare values of the same enum type.


Diffs
-----

  src/tests/api_tests.cpp 61d516ce24401199bac9b3984158e9257dda072c 


Diff: https://reviews.apache.org/r/70721/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message