mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70641: Changed Agent GET_STATE for completed executor's tasks (Part 2).
Date Fri, 24 May 2019 22:01:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70641/#review215513
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/api_tests.cpp
Lines 6846 (patched)
<https://reviews.apache.org/r/70641/#comment302246>

    frameworkId->value()



src/tests/api_tests.cpp
Lines 6880 (patched)
<https://reviews.apache.org/r/70641/#comment302247>

    How about verifying the latest state of this task?


- Greg Mann


On May 14, 2019, 12:39 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70641/
> -----------------------------------------------------------
> 
> (Updated May 14, 2019, 12:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9750
>     https://issues.apache.org/jira/browse/MESOS-9750
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another code path where an executor can "complete" with
> a non-terminal task (based on last status update).  This happens when
> the Framework or Master TEARDOWN calls are made, for a framework.
> If the executor does not send a TASK_KILLED in time, the agent will
> still mark the executor as complete and kill it.
> 
> Unlike the other code path, this one does not require an agent restart.
> The agent in this state will return a GET_STATE response where
> non-terminal tasks of a completed executor (of a completed framework)
> will appear under `launched_tasks`.  This may provide misleading
> information about the total number of tasks running.
> 
> This commit adds extra logic to place these non-terminal tasks under
> the `terminated_tasks` category, and adds a regression test.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 95f05a18c7905d5032de1cd35726ac3a17f0b682 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70641/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> make check
> src/mesos-tests --gtest_filter="*TeardownAndGetStateWithNonTerminalCompletedTask*" --verbose
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message