mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70705: Added comment regarding tracking role consumed quota.
Date Fri, 24 May 2019 20:03:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70705/#review215504
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 1716 (patched)
<https://reviews.apache.org/r/70705/#comment302241>

    no need to say it's in the Role struct, seems clear ?


- Benjamin Mahler


On May 23, 2019, 2:43 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70705/
> -----------------------------------------------------------
> 
> (Updated May 23, 2019, 2:43 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added comment regarding tracking role consumed quota.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp ccca391fbf73d9aa9c31f7552e39fb78c242e242

> 
> 
> Diff: https://reviews.apache.org/r/70705/diff/1/
> 
> 
> Testing
> -------
> 
> M/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message