mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.
Date Wed, 22 May 2019 21:41:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/
-----------------------------------------------------------

(Updated May 22, 2019, 9:41 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Addressed Greg's comments.


Bugs: MESOS-9785
    https://issues.apache.org/jira/browse/MESOS-9785


Repository: mesos


Description
-------

If one subscribes to master's `/api/v1` endpoint after a master failover
but before an agent reregistration, frameworks recovered through the
agent registration should be notified to the subscriber, otherwise
recovered tasks will have framework IDs referring to frameworks unknown
to the subscriber.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
  src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
  src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 


Diff: https://reviews.apache.org/r/70651/diff/2/

Changes: https://reviews.apache.org/r/70651/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message