mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70670: Simplified the `Framework::update()` method.
Date Wed, 22 May 2019 17:18:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70670/#review215465
-----------------------------------------------------------


Ship it!




Thanks!

Not for this change, but there's a lot of expensive set construction and string copying in
this function when computing the added and removed roles. Feel free to send another patch
later that improves the efficiency of the function.


src/master/framework.cpp
Lines 503 (patched)
<https://reviews.apache.org/r/70670/#comment302183>

    newline, 'They should'


- Benjamin Mahler


On May 21, 2019, 1:53 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70670/
> -----------------------------------------------------------
> 
> (Updated May 21, 2019, 1:53 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that ignoring some fields on re-subscription is performed outside
> of this method, we can replace the fragile filed-by-field copying
> of `FrameworkInfo` on updates with copying it as a whole.
> 
> 
> Diffs
> -----
> 
>   src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b 
> 
> 
> Diff: https://reviews.apache.org/r/70670/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message