mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.
Date Wed, 22 May 2019 12:48:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70549/
-----------------------------------------------------------

(Updated May 22, 2019, 5:48 a.m.)


Review request for mesos, Alexander Rukletsov, Andrei Sekretenko, and Benjamin Mahler.


Changes
-------

Addressed AlexR's comment.


Bugs: MESOS-9640
    https://issues.apache.org/jira/browse/MESOS-9640


Repository: mesos


Description (updated)
-------

A new authorizable action `UPDATE_QUOTA_WITH_CONFIG` is added.
This disambiguates with the old action `UPDATE_QUOTA` which
are used for the old `SetQuota` and `RemoveQuota` calls.
`UPDATE_QUOTA` action requires `QuotaInfo` as the object while
the new `UpdatedQuota` call uses `QuotaConfig`. To keep it compatible
with any external authorization modules, a new action  is introduced.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.proto e2740c402732bb37db991ec92b9301e58b33215b 
  src/master/master.hpp 5ad128d00d3cdf0dca89eb637ae196987bdce412 
  src/master/quota_handler.cpp a18d8bafda5604d1844f7f7ed31d4ea80fbf6d04 
  src/tests/master_authorization_tests.cpp ee69910a34416728bf14ed23f4a6faae6c1204a0 


Diff: https://reviews.apache.org/r/70549/diff/3/

Changes: https://reviews.apache.org/r/70549/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message